This seems a solid solution!
Does it suit everyone though? Perhaps some people may want to work with user-mode services in the CLI.
Edit: however, since the CLI usage mainly comes from this community and will likely remain more technically inclined people, I would be happy to go with a general consensus. So if you have an opinion on this, please say.
I think the frustration I have experienced by it is worth avoiding. It has been pretty intense.
But it could also be that new users donāt need to stumble through active development.
Right, yeah, but, if enough people wanted user-mode service support, and it could be mitigated through the use of subcommands, that could be a viable alternative. I donāt have a strong opinion on it myself. Personally I will run nodes on server-like machines at home, so I donāt think I would use user-mode services.
I think people need to know there is now the 2 methods. With or without sudo and the 2 methods produce different results
Maybe also when node-manager runs its output says user mode or system mode. And maybe the --help also indicates this difference and the directories it defaults to.
The fact sudo will result in major differences of node service operation & directories is strange behaviour for many people
Right, yeah, Iām already acknowledging that there is a problem.
The README and the CLI documentation has already been updated.
Iām interested more in further changes that can make things easier. Or, like I said, we can take the functionality out of the CLI and just have it for the TUI.
Iāve dipped my toes every so often and been burned so kept out each time waiting for things to settle before trying again.
That documentation is helpful but I think it would be better made foolproof, or do I mean @Josh-proof ā¦
My guess is that most will be fine with user mode so that would be a good default, needing some special action to switch to āsuperā mode, which those wanting super mode would be fine setting up.
Iād suggest everything is user mode until a āsuperā setting is enabled, which persists in some node-nanager config until disabled.
Setting āsuperā mode would be a node-manager command. Not needed for those using user mode, and used once after installing by those wanting super mode. If set, node-manager should error unless it has the privileges it needs.
Thanks for the input. I think that could be quite a good solution.
Would any more people around here be intending to go with user-mode services if that was available?
Ooooh game on!!
What I was saying is that for the cli, the node-manager outputs the directory it is using and the mode it is setting up the services for.
This allows a feedback to the user to confirm or see if they made a mistake by forgetting sudo or by using sudo when they didnāt mean to.
Itāll help the new users especially and the tired seasoned user
Maybe even a --user and --system being needed defaulting to --user and if sudo is used then abort or --system used without sudo then abort with message that they need to use sudo as an additional
So what happens if I am using root terminal (acting as root in a terminal) will it be system or user services. Depends on how the code works
I will study this and then make my mind up. If the TUI can eventually successfully set up --upnp or --home-network (if that survives) for the casual user than that would be preferable.
EdIT : OK I pulled the latest and will read the new docs.
@chriso what features do you recommend when building this? RIght now I just built with cargo build --release --features=upnp
Output of directories used would be fine. I just need to clarify something here though. Are you saying there should be a prompt for input to confirm before proceeding with whatever operation?
Yeah, I had mentioned the possibility of using flags. It does mean though that they would need to be used almost everywhere, and that might be tedious. I quite like @happybeing idea of setting it to system-wide mode once.
I would need to validate the assumption here, but I think you would get system-wide services when running as root.
Right, yeah, but what we are interested in now is, in light of user-mode services, what do we want to do specifically with the CLI?
I donāt think there are generally any features required for the node manager build. If you want to use upnp with the node manager, you need to have a node binary that is built with that feature. So applying that feature to the node is more important.
no, just let the user know mode (user/system) & directories used
since user mode will be the norm for most then I would default to that and only for system mode the flag is required.
Error output if user mode but sudo used. OR --system without sudo or root terminal
Publish 2 versions?:-
safenode-manager-user
safenode-manager-system
User version to not need sudo and a system version that does? The commands and flags can be universal and not confusing for users and when people post outputs.
Iām actually still not completely sure that user mode would be the most used for the CLI. The audience for the CLI will be more technical people who understand the distinction between system-wide and user-mode services. There is an active user session required for user-mode services and that is not appropriate for all use cases.
Sorry, but I think from a release management point of view, there would be quite a bit of overhead with this. Conditional compilation may also be required.
Whichever is default I prefer having a mode flag (system|user) which persists until changed.
This allows you to catch when people forget they are using one, say system, and give a user command without sudo, and then wonder why it hasnāt done what they expect because they earlier set up for system.
@chriso @joshuef Version 8 of safenode-manager is not showing any balances on the net test network
Used
sudo safenode-manager add --count 20 --node-port 12001-12030 rpc-port 14001-14030
sudo safenode-manager start --interval 180000
after all started, I ran vdash to keep an eye on them, and showing impressive earnings since I got on right at the start and people were uploading
But just now tried
sudo safenode-manager balance
And I get zero balances for all nodes.
Why am I getting zero balances when the logs show they all earned something? I did not include any discord info, never have on this device, nor ever run the launcher on this device. Not even using this ISP connection. That was done on the other device and ISP connection
I suspect that all nodes with or without discord info is sending the earnings to the maidsafe wallet for tallying
Thanks for the report. Depending on priorities, I may look at this on Tuesday, but if not, some time soon.