Jim: Please hold back for the time being folks. Just updating our nodes first
5 Likes
Toivo
August 3, 2024, 10:47am
5657
Inching closer and closer…
libp2p:master
← umgefahren:transport-redesign
> I think this is a fine solution. It is known that one of the disadvantages of … enabling port reuse is that you can only have a single connection to another peer. Thus, our best way of fulfilling the request to establish another connection is to ignore port reuse and simply allocate a new port. I think that is better than the connection failing.
>
> I have two suggestions for slightly revising the log and bumping its severity.
I'm glad you are fine with the solution and I implemented your suggestions. I'm ready to merge.
13 Likes
AutoNATv2 has been merged!
libp2p:master
← umgefahren:implement-autonat-v2
opened 02:44PM - 04 Aug 24 UTC
## Description
<!--
Please write a summary of your changes and why you made … them.
This section will appear as the commit message after merging.
Please craft it accordingly.
For a quick primer on good commit messages, check out this blog post: https://cbea.ms/git-commit/
Please include any relevant issues in here, for example:
Related https://github.com/libp2p/rust-libp2p/issues/ABCD.
Fixes https://github.com/libp2p/rust-libp2p/issues/XYZ.
-->
Closes: #4524
This is the implementation of the evolved AutoNAT protocol, named AutonatV2 as defined in the [spec](https://github.com/libp2p/specs/blob/03718ef0f2dea4a756a85ba716ee33f97e4a6d6c/autonat/autonat-v2.md).
The stabilization PR for the spec can be found under libp2p/specs#538.
The work on the Rust implementation can be found in the PR to my fork: umgefahren/rust-libp2p#1.
The implementation has been smoke-tested with the Go implementation (PR: libp2p/go-libp2p#2469).
The new protocol addresses shortcomings of the original AutoNAT protocol:
- Since the server now always dials back over a newly allocated port, this made #4568 necessary; the client can be sure of the reachability state for other peers, even if the connection to the server was made through a hole punch.
- The server can now test addresses different from the observed address (i.e., the connection to the server was made through a `p2p-circuit`). To mitigate against DDoS attacks, the client has to send more data to the server than the dial-back costs.
## Notes & open questions
<!--
Any notes, remarks or open questions you have to make about the PR which don't need to go into the final commit message.
-->
### Notes
#### IPv4 & IPv6
There are open questions on how to handle cases where a client is only reachable over IPv4 or IPv6, but the server is connected to a network with an incompatible IP family.
Relevant comments in the other PR:
- [Original assessment](https://github.com/umgefahren/rust-libp2p/pull/1#issuecomment-2167215625)
- [@thomaseizinger assessment](https://github.com/umgefahren/rust-libp2p/pull/1#issuecomment-2168171137)
- [Decision](https://github.com/umgefahren/rust-libp2p/pull/1#issuecomment-2171116249)
The decision was made to ship the improvement in a later version, when we know more about the issue. It's still an improvement over AutoNATv1.
Handling these cases would be easier once rust-lang/rust#86442 is merged.
#### Picking algorithm
The spec proposes a picking algorithm for the address tested by the server. At the moment, the server is just using the first address sent by the client. An improvement to this algorithm can be implemented later.
### Open questions
- [x] Should we replace the deprecated v1 version in libp2p-server?
## Change checklist
- [x] I have performed a self-review of my own code
- [x] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] A changelog entry has been made in the appropriate crates
This work was sponsored by the Filecoin grant program: filecoin-project/devgrants#1421
16 Likes
Just how agog are we all feeling this afternoon?
3 Likes
Toivo
August 8, 2024, 3:00pm
5660
So next thing to look out: when release of 0.54 of LibP2P?
Should be a matter of day(s).
4 Likes
Josh
August 9, 2024, 10:41pm
5662
+1 for Sanford Police. or are they serious… never know.
6 Likes
Josh
August 9, 2024, 10:53pm
5664
Ahhhhh i seee , I just looked at followers and thought they must be legit.
Got me.
3 Likes
JPL
August 9, 2024, 11:58pm
5665
Your pisstake antennae have rusted in the humid Florida air.
5 Likes
Josh
August 10, 2024, 12:17am
5666
JPL:
Florida air.
Ahh its the last night of my Caribbean vacation, my reading skills are blurry cheap rum does wonders to perception.
5 Likes
you always know when Mike Hunt is involved they are taking the c**t
3 Likes
Josh
August 10, 2024, 11:29am
5668
Josh:
cheap rum does wonders
Double whammy, I even posted in the complete wrong thread.
4 Likes
neo
August 10, 2024, 11:31am
5669
Somebody actually registered a company here with that name and had it on their work vehicle.
1 Like
I worked for the nicest MD you can imagine whose name was Mike Hunter.
1 Like
neo
August 10, 2024, 11:37am
5671
Their parents seemed to have a sense of humour.
Just like the parents of Ronald Macdonald, Or the other Macdonald name Donald Macdonald
2 Likes
LJlang
September 2, 2024, 1:20pm
5672
Guys, I’m very intrigued by what Bux and the team are planning on launching in October.
Is this something that is obvious to others, and perhaps I’m just not very good at reading between the lines? Or is it generally a mystery to all of us? Does anyone have any guesses about the plans? Given that the message seems to be “it’s not what we expect” and there is an assumption that we will be delighted …if I read between the lines of what David et al. have written. What do we think it will be? Especially given the not-so-smooth sailing of the beta test, tech issues and longer than expected developement of APIs?
And what’s the deal with Ethereum EVM L2 payments too? What part might this have to play in the upcoming launch (if anything…) I wonder ?
2 Likes
neo
September 2, 2024, 1:22pm
5673
Well I can say she has said nothing even to mods here or on discord.
The plans have to be checked out from a couple of angles and this will be why she is not saying anything to anyone outside of Maidsafe and its board members.
4 Likes
riddim
September 2, 2024, 1:23pm
5674
i guess we should start working for maidsafe …
5 Likes
I hear they are looking for developers, support staff, proof-readers and more.
Many of these jobs can be applied for by submitting suitable PRs. A good PR and a commitment to work for tokens rather than real money will get you further than a pristine CV.
2 Likes