Why do git tags of e.g. maidsafe/safe_ffi point to gh-pages commits?

Development
1

The older version git tags point to the source code itself:

However, starting with 0.4.1, newer tags point to the documentation (gh-pages):

Is there a specific reason was this changed? It seems useful to be able to check out a certain version of the source code, more useful than checking out an old version of the documentation site, which is stored as a directory per release anyway.

I see the same is true for safe_vault, where it changed around 0.3.0. Probably for other packages as well, but haven’t checked.

The reason I noticed this is that I wanted safe_ffi 0.4.5 specifically (as this is compatible with the current launcher), had to look up the commit in the log. Is there a better way?

5 Likes
2

I bet they just messed up. At this point, probably not. You have to get it at the commit hash you want. It is strange they did this…and strange it was done on two projects.

You might want to file a bug on Log in with Atlassian account. Link it here and I’ll vote for it.

3

This is maybe a bug or intentional (I might get corrected by the team) due to rust / npm versioning. You should be able to check out a particular version or add this in your cargo.toml/packages.json. I would have thought git tags also worked though (git checkout tags/<tag_name> -b <tag_name>). I will take a peek as well though. @Krishna_Kumar may know more.

1 Like
4

He is wondering why master wasn’t the one tagged, not whether it was tagged. If he were to checkout 0.5.0, he would be not getting the code branch but the GitHub pages branch.

5

Ah right, yes that’s a bug in our scripts then. We will get that resolved. There is a script runs when we do a PR with Version update to X.X.X it does a tag git, create the docs and prep for release (cargo release or npm). Something is not right there.

2 Likes
6

As @dirvine mentioned, this seems to a bug in our github tag deploy script where we seem to checkout to the gh-pages branch to update docs and generate tags in that branch than switch back to master before tagging. Cheers for highlighting this.

For now if you do wish to check out to a particular version you can use this command which should hopefully get you to the right point in history

so if you want to switch to version 0.4.5 of safe_ffi, it’d be something such as:

git checkout `git log --grep=‘Version change to 0.4.5’ --pretty=format:‘%h’ -n 1`

hope that helps.

3 Likes
7

My bad - I broke the script a while back :frowning:

Thanks for bringing this up @wumpus. The script should be fixed now, so future tags should be applied correctly. I’ll see what I can do to rectify the damage I’ve done.

6 Likes
8

The incorrect tags have now been fixed too.

To bring these to your fork, you should be able to do something like:

git fetch https://github.com/maidsafe/safe_ffi.git --tags

2 Likes
9

Yes, I can confirm that is solved. Thanks everyone!

5 Likes