There’s a PR being worked on by Gabriel to implement safe folders commands to create folders on the network using registers and upload/download directory trees.
Here’s the underlying folders API:
maidsafe:main ← bochaco:feat-folders-api
opened 08:48PM - 31 Jan 24 UTC
## Description
### Summary generated by Reviewpad on 31 Jan 24 20:48 UTC
Thi… s pull request includes the following changes across multiple files:
- In the `subcommands/mod.rs` file, a new module `folders` has been added, along with the necessary command handling for the `SubCmd::Folders` variant.
- In the `subcommands/mod.rs` file, the `FoldersApi` trait has been imported.
- In the `subcommands/folders.rs` file, the implementation of the `FoldersApi` struct has been added. The struct provides APIs for interacting with folders and includes methods such as `new`, `wallet`, and `upload`.
- In the `folders.rs` file, the implementation of the `FoldersCmds` enum has been added, which includes variants for `Upload` and `Download` operations.
- In the `folders.rs` file, helper functions `upload_folder` and `download_folder` have been implemented to handle the actual upload and download operations.
- In the `api.rs` file, a blank line has been added at line 62, and there is an additional comment for instantiating a new client.
Please review the changes in the diff for any potential issues or improvements.
Here’s the safe folders CLI command implementation:
maidsafe:main ← bochaco:feat-folders-api
opened 08:48PM - 31 Jan 24 UTC
## Description
### Summary generated by Reviewpad on 31 Jan 24 20:48 UTC
Thi… s pull request includes the following changes across multiple files:
- In the `subcommands/mod.rs` file, a new module `folders` has been added, along with the necessary command handling for the `SubCmd::Folders` variant.
- In the `subcommands/mod.rs` file, the `FoldersApi` trait has been imported.
- In the `subcommands/folders.rs` file, the implementation of the `FoldersApi` struct has been added. The struct provides APIs for interacting with folders and includes methods such as `new`, `wallet`, and `upload`.
- In the `folders.rs` file, the implementation of the `FoldersCmds` enum has been added, which includes variants for `Upload` and `Download` operations.
- In the `folders.rs` file, helper functions `upload_folder` and `download_folder` have been implemented to handle the actual upload and download operations.
- In the `api.rs` file, a blank line has been added at line 62, and there is an additional comment for instantiating a new client.
Please review the changes in the diff for any potential issues or improvements.
And here’s the draft PR to track:
maidsafe:main ← bochaco:feat-folders-api
opened 08:48PM - 31 Jan 24 UTC
## Description
### Summary generated by Reviewpad on 31 Jan 24 20:48 UTC
Thi… s pull request includes the following changes across multiple files:
- In the `subcommands/mod.rs` file, a new module `folders` has been added, along with the necessary command handling for the `SubCmd::Folders` variant.
- In the `subcommands/mod.rs` file, the `FoldersApi` trait has been imported.
- In the `subcommands/folders.rs` file, the implementation of the `FoldersApi` struct has been added. The struct provides APIs for interacting with folders and includes methods such as `new`, `wallet`, and `upload`.
- In the `folders.rs` file, the implementation of the `FoldersCmds` enum has been added, which includes variants for `Upload` and `Download` operations.
- In the `folders.rs` file, helper functions `upload_folder` and `download_folder` have been implemented to handle the actual upload and download operations.
- In the `api.rs` file, a blank line has been added at line 62, and there is an additional comment for instantiating a new client.
Please review the changes in the diff for any potential issues or improvements.
14 Likes