New Release: Vault Phase 1 (real vault)

Congratulation to the whole team for this great milestone! Just had some time to test the new cli commands with test safecoin and it feels great! :slight_smile:

Just two things that quickly came to my mind while playing around:

  1. I find the parameter sorting for transfer somehow unintuitive. I understand that there might be a reason for it as there could be something like a default and therefore it makes sense for to come first? I think it would be easier to read if we specify it explicitly with mandatory options --from --to

  2. The documentation states that for a transfer you can use either a wallet or a SafeKey address. However if you look at the output below (where I try to address a SafeKey address) I’m somehow confused by the error message:

“[2019-08-31T19:21:39Z ERROR safe] safe_cli error: [Error] InvalidInput - The ‘from_url’ URL doesn’t target a SafeKey or Wallet, it is: Raw (SafeKey)

Is it a SafeKey or not? ^^

Full console output:

PS C:\Users\Alexander\Desktop\safe> .\safe wallet create --preload 13.37 --test-coins Wallet created at: “safe://hnyybyqt5ubtmaxpi37tcwtxf5w7y431yjsdakas6ba7r8gpio11on8fi1y9e”
New SafeKey created at: “safe://hbyyyybgy1oyrssehd7on9y17m179jakkseamcux7cmspcauom1gx75ugb”
Preloaded with 13.37 coins
Key pair generated:
Public Key = 981280096b2383ec05f04bab977e9c29564616c9bfac5d9acc4e0b919fddccc15415ddc9e10cda2ddbec0c8d36814f76
Secret Key = c8843084f30f444e26fe09fecb047c3e63d7460d34c2530c5ae1eb824b91c332
PS C:\Users\Alexander\Desktop\safe> .\safe wallet transfer 0.37 safe://hnyybyqt5ubtmaxpi37tcwtxf5w7y431yjsdakas6ba7r8gpio11on8fi1y9e safe://hnyybyqt5ubtmaxpi37tcwtxf5w7y431yjsdakas6ba7r8gpio11on8fi1y9e Success. TX_ID: 7386616574070973832
PS C:\Users\Alexander\Desktop\safe> .\safe wallet transfer 0.13 safe://hbyyyybgy1oyrssehd7on9y17m179jakkseamcux7cmspcauom1gx75ugb safe://hbyyyybgy1oyrssehd7on9y17m179jakkseamcux7cmspcauom1gx75ugb [2019-08-31T19:21:39Z ERROR safe] safe_cli error: [Error] InvalidInput - The ‘from_url’ URL doesn’t target a SafeKey or Wallet, it is: Raw (SafeKey)

7 Likes